Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Persona 3 Reload support #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Persona 3 Reload support #120

wants to merge 2 commits into from

Conversation

codeugo
Copy link

@codeugo codeugo commented Feb 3, 2024

Game name: Persona 3 Reload
Game package name: SEGAofAmericaInc.L0cb6b3aea_s751p9cej88mt

Used the method referenced by illusion0001 in #114 .

@jakemer
Copy link

jakemer commented Feb 6, 2024 •
edited
Loading

Hi @codeugo - Just happened to look at this and wanted to suggest adding an entry to the main README.md in the "Supported Games" legend/table

revanmj
revanmj reviewed Feb 7, 2024
View reviewed changes
main.py Outdated Show resolved Hide resolved
@iiTzCitrus
Copy link

Thanks bro I successfully changed my xgp data into steam data.

@codeugo
Copy link
Author

codeugo commented Feb 9, 2024

I modified the readme based on @jakemer advice and fixed the spacing on @revanmj advice.
Let me know if something else is bothering you.

@iiTzCitrus
Copy link

iiTzCitrus commented Feb 9, 2024 via email

@jakemer
Copy link

jakemer commented Feb 10, 2024

@codeugo one more thing in regards to the README.md - You might want to remove this game's entry under the "Incompatible games" https://github.com/Z1ni/XGP-save-extractor/blob/main/README.md?plain=1#L61

@codeugo
Copy link
Author

codeugo commented Feb 10, 2024

@codeugo one more thing in regards to the README.md - You might want to remove this game's entry under the "Incompatible games" https://github.com/Z1ni/XGP-save-extractor/blob/main/README.md?plain=1#L61

I think I've already done it, but I could be wrong. I'm honestly not used to pull request, so please enlighten me if I didn't remove the game's entry in the "Incompatible Games" list.

XGP-save-extractor/README.md

Line 61 in 8b241e5

| Forza Horizon 4 | [#71](https://github.com/Z1ni/XGP-save-extractor/issues/71) |

@jakemer
Copy link

jakemer commented Feb 12, 2024

@codeugo My bad! I missed it in the diff - looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revanmj revanmj revanmj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codeugo @jakemer @iiTzCitrus @revanmj